Taxonomy CRUD Support via TaxonomyStore#3
Conversation
- Added TaxonomyStore interface in cms-api. - Implemented FileTaxonomyStore in cms-core with support for atomic writes and YAML/TOML reading. - Integrated TaxonomyStore into DB and TaxonomyConfiguration. - Ensured thread safety and consistent serialization. Co-authored-by: thmarx <232434+thmarx@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Introduced TaxonomyStore interface for CRUD operations. - Implemented FileTaxonomyStore supporting YAML and TOML. - Separated taxonomy definitions from value files. - Added support for atomic file writes and thread safety. - Refactored TaxonomyConfiguration to use the new store while maintaining live reload support. - Included unit tests and fixed related configuration loader issues. Co-authored-by: thmarx <232434+thmarx@users.noreply.github.com>
1 participant
Implemented a new taxonomy storage architecture that supports CRUD operations while maintaining compatibility with the existing filesystem-based configuration.
Key changes:
TaxonomyStoreinterface for managing taxonomies and their values.FileTaxonomyStorewhich handlesconfig/taxonomy.yamlandconfig/taxonomy.<slug>.yamlfiles.TaxonomyConfigurationto delegate loading to the store, ensuring that manual file edits (detected via reload strategies) are correctly reflected in the system.ConfigurationFactoryandFileDBto provide and use the new store.PR created automatically by Jules for task 16415646078489418794 started by @thmarx