docs: define SION reusable workflows and skip the upstream tree in checks - #5
Merged
Merged
Conversation
…ecks - The whitespace check in selection and the docs check skip paths under upstream/, so upstream's files stay as upstream ships them. - SION's reusable workflows are SION's own files. Before a job runs upstream code, they place the pinned release's upstream/ tree at the workspace root, where upstream's composite actions expect it. - An upstream sync brings upstream workflow changes into the SION reusable workflows that follow them, in the same pull request. - A refused mailbox input gets a refused result file in outbox/, at the path LINA's schema defines. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Settles how SION checks, runs and follows the upstream ClawSweeper tree under
upstream/.selectionwhitespace check (git diff --check/git show --check) excludesupstream/with a pathspec, and the docs check skips Markdown underupstream/. Upstream c73bf38 holds 12 hits forgit diff --checkagainst an empty tree: 3 trailing-whitespace lines in a recorded proof transcript and 9 intentional conflict markers in a repair test. Without the exclusion, the PR that brings in the tree could not passfoundation. A-whitespaceattribute alone would not help, because Git reports conflict markers regardless of it. Upstream's ownpnpm run check(includingcheck:docsandformat:check) covers the tree. The CI policy, the workflow step and the docs check script now say the same thing.sion.md, Source layout and the new "Running upstream code"). SION's reusable workflows are SION's own files in the root.github/workflows/, and each one names the upstream workflows it follows. Upstream's composite actions treat$GITHUB_WORKSPACEas ClawSweeper's code root: local./.github/actions/<name>paths,scripts/copied from the workspace, the deployment revision fromgit -C "$GITHUB_WORKSPACE" rev-parse HEAD, and target and state checkouts as direct children. A workflow cannot overrideGITHUB_WORKSPACE, so a SION reusable workflow checks out the pinned release and runsgit read-tree --reset -u HEAD:upstream. That places theupstream/tree at the workspace root, withHEADstill the release commit.upstream/.github/workflows/without conflicts and reach no SION workflow on their own. The sync PR reviews them and updates the corresponding SION reusable workflows in the same PR. The "Costs" section names this as the second place where following upstream takes recurring work.refusedresult file inoutbox/. The file names the input and carries the error. Outbox result paths follow LINA's schema and fixtures.Verification
node .github/scripts/check-docs.mjs: OK (14 documents).node --test .github/scripts/*.test.mjs: 29 pass. The new docs-check test fails against the previous script and passes with the change.actionlintv1.7.12, with the pinned checksum verified: no findings.git diff --cached --check -- . ':(exclude)upstream/': clean.upstream/: the fullgit diff --checkreports 12 hits, the excluded form reports none, and a whitespace error at the root is still caught.git read-tree --reset -u HEAD:upstreamwas tried in a scratch checkout. The work tree became the subtree, andgit rev-parse HEADstayed at the tagged commit.sion.md#source-layoutandci.md#upstream-treeare unchanged.Compatibility and recovery
The CI step only narrows the paths it checks. No
upstream/tree exists yet, so current results do not change.🤖 Generated with Claude Code