Skip to content

docs: stage the RUMI manifest and answer refused inputs in kind - #7

Merged
thisisjun786 merged 1 commit into
devfrom
docs/review2-fixes
Oct 1, 2026
Merged

thisisjun786 merged 1 commit into
devfrom
docs/review2-fixes

Conversation

@thisisjun786

@thisisjun786 thisisjun786 commented Oct 1, 2026 •

Copy link
Copy Markdown
Owner

Summary

Closes the RUMI side of the second canon review across LINA, SION and RUMI, in docs/design/rumi.md:

  • Manifest in two stages. The vault stage writes only the RUMI-owned vault fields (vault id, vault format version, last RUMI version); the vault format names their keys. The LINA link stage adds the declaration object (product version, rumi protocol versions, capabilities) from LINA's schema for sibling declarations, which LINA's sibling tag carries. When RUMI writes the declaration, its product version is the RUMI release in charge of the vault, and LINA selects the RUMI row of its supported-combination table by it. Layout, CLI status and the envelope section follow.
  • Refused and failed results. A refused or failed input is answered with the record kind that answers it, picked from the input's path: add for an inbox/ item, brief for a request. The record carries none of its kind's content, only the input it answers, effect_state and error. An input at an unsupported envelope version is answered the same way.
  • Web fetch tool. It comes with the kit's document parsing. A new bullet names LINA's sibling tag and what RUMI takes from it: the rumi payload schemas and fixtures, the declaration schema, and document parsing with the web fetch tool, passage anchors and citation checks.
  • Inbox front matter. The shared field list gains the sender, matching LINA's materials and knowledge contract.
  • Open in RUMI. RUMI defines the link format together with LINA during the RUMI app stage.
  • The kit's protocol types are named "protocol types", as the kit carries the Go types of every connection.

LINA's host protocol, materials and surfaces contracts take the matching wording in a separate LINA PR.

Verification

  • node .github/scripts/check-docs.mjs: passed.
  • node --test .github/scripts/*.test.mjs: 28 passed, 0 failed.
  • git diff --check: clean.
  • Checked every in-file # anchor in rumi.md with a script: all resolve. No headings changed, and no other document links to an anchor in rumi.md other than #repository-and-releases, which is unchanged.
  • Read the changed sections against the LINA host protocol, materials and runtime contracts and the RUMI roadmap stages.

Compatibility and recovery

Contract text only. No code, data or configuration changes.

🤖 Generated with Claude Code


Devin Review

Fill .rumi/manifest.json in two stages: the vault stage writes the
RUMI-owned vault fields (vault id, vault format version, last RUMI
version), and the LINA link stage adds the declaration object from the
schema in LINA's sibling tag. LINA picks the RUMI row by the
declaration's product version.

Answer a refused or failed input with the kind that answers it, picked
from the input's path: add for an inbox item, brief for a request, with
no content and with effect_state and error. Unsupported envelope
versions are answered the same way.

Take the kit's web fetch tool with its document parsing from LINA's
sibling tag, add the sender to the shared inbox front matter, and have
RUMI define the Open in RUMI link format with LINA in the RUMI app
stage.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review ✅ Completed 2026-10-01T18:48:10.668401Z a9b7398 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@thisisjun786
thisisjun786 merged commit b909eec into dev Oct 1, 2026
7 of 11 checks passed
@thisisjun786
thisisjun786 deleted the docs/review2-fixes branch October 1, 2026 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant