Skip to content

docs: own the vault format and close the LINA link gaps - #6

Merged
thisisjun786 merged 2 commits into
devfrom
docs/review-fixes
Oct 1, 2026
Merged

thisisjun786 merged 2 commits into
devfrom
docs/review-fixes

Conversation

@thisisjun786

@thisisjun786 thisisjun786 commented Oct 1, 2026 •

Copy link
Copy Markdown
Owner

Summary

Resolves the final review findings against the RUMI design contract and policies.

  • Vault format ownership: this repository's vault format specification defines notebook files, source cards, front matter keys (including rumi_id and the keys LINA writes on inbox/ items), the .rumi/ layout, inbox filing rules and the manifest's vault fields. LINA's schema defines the envelope, payload kinds and sibling declaration. Each rumi protocol version names the vault format version it covers; the vault stage writes vault format version 1 first.
  • Manifest: vault id (created on first open, never changes), vault format version, and the declaration (product version from the vault stage; protocol version list and capabilities from the LINA link stage). The product version is the release that last wrote the vault and selects LINA's supported row.
  • Results: every LINA input (inbox/ item, request) gets exactly one result record, either the add/brief or a refused/failed record with error. An unsupported envelope version gets a refused record in a version RUMI speaks. Writing a digest note writes an add record.
  • Mailbox: common front matter fields aligned with LINA's materials contract; items without a notebook follow the inbox filing rules; a non-text file and its Markdown companion are one source card.
  • Research: web gathering uses the endpoint's web search tool or the kit's fetch tool; unattended requests use a revocable standing network grant from RUMI's settings. The data-egress sentence now covers web queries.
  • Runtime: rumi serve runs as the user's service and notices input through vault commits; kit module path github.com/thisisjun786/lina/kit vendored into third_party/ with replace; fixtures vendored from the same LINA tag with digests; tools report unsupported on Windows until the kit sandbox is verified there.
  • Identity and CLI: the rumi_id format is fixed by vault format 1 before later stages assign ids; RUMI lists its own commit hashes in .rumi/local/; the vault stage's CLI scope is stated.
  • App links: "LINA connected" is judged from LINA input in the vault; "Open in RUMI" names vault id, rumi_id and passage anchor; link formats, binary publication and service registration are deferred.
  • Policies: new docs/policy/dependencies.md applying LINA's policy to this repository (Go, Flutter and pub, vendored kit, fixtures and design package; opencodex and Node.js runtime clauses excluded). docs/policy/ci.md gains a Go components section (components and dependencies jobs, path mapping, exhaustive analyzer). Release manifest adds the design package tag and Flutter toolchain.
  • Manifesto and AGENTS.md: research requests and cited briefs in "Alongside LINA"; design contracts stated in the present tense.

Verification

  • node .github/scripts/check-docs.mjs: local file targets OK.
  • node --test .github/scripts/*.test.mjs: all pass.
  • git diff --check: clean.
  • Internal heading anchors in the changed documents resolved by script; external URLs not checked.
  • New policy file is Markdown directly under docs/policy/, so CI classifies it as documentation.

Compatibility and recovery

Documentation only. No code, data or configuration changes.

🤖 Generated with Claude Code


Devin Review

Define the vault format as this repository's specification and the
manifest fields by stage, including the vault id and RUMI's sibling
declaration. Give every LINA input one result record, record digests,
state the inbox filing rules, web gathering and network grant, the
engine service, the kit module path, fixture pinning and the Windows
sandbox dependency. Add the dependency policy and the Go components
section of the CI policy, and align the manifesto and agent rules.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review ✅ Completed 2026-10-01T17:22:42.130803Z 9b96900 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Devin Review

Comment thread docs/design/rumi.md Outdated
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@thisisjun786
thisisjun786 merged commit fe705ef into dev Oct 1, 2026
6 checks passed
@thisisjun786
thisisjun786 deleted the docs/review-fixes branch October 1, 2026 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant