fix(editor): timeline inside the left column per 346:9830 - #74
Merged
Merged
Conversation
…eft column Pre-alpha feedback against frame 346:9830: the timeline was spanning the full window width below both the stage and the panel, but the mock nests it inside the left column so it ends where the full-height Create panel begins. App.tsx now wraps stage + timeline in an editor-left column with the panel beside them. Along the way, the details the rendered frame exposed: the preview card picks up the layered ap shadow, the panel takes the separating hairline (stage loses its border), the transport's left buttons are undo/redo (wired with disabled states; the header dropped them in the redesign), the header action is a primary Export button with a secondary Settings, and text chips wear the mock's rosé action tint instead of the V0 amber. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Layout corrections against the
Generated the first cutframe (346:9830) — first review with the frame actually rendered (the old View seat's rate cap hit before I could screenshot it during the shell PR).Cmd+\) still collapses to just the stage.--ap-shadow-smfrom the frame; the panel takes the separating hairline (border-left) instead of the stage.undoEdl/redoEdlwith disabled states — they'd been keyboard-only since the header dropped them); volume/play/time/zoom unchanged.Renderer-only — HMR covers it.
Test plan
Made with Cursor