Repository navigation
feat(critique): benchmark intake + apply-fixes in the session (v1.5 PR9) - #70
Merged
Merged
Conversation
…ssion Completes the critique flow per the V1 frames. In Critique mode the composer grows a benchmark dropzone (imports into benchmarks/ and runs feature extraction immediately) and its field doubles as a paste-a-link intake — URLs fetch the related video through benchmark:fromUrl instead of running a turn. Benchmark and reference attachments render as thumbnails under the user bubble, agent switches draw a "Critique has joined the session" separator, and the critique card gains the "Apply the suggested changes" widget: a store action that runs autotune with streamed status, marks the card applied, and logs the re-tune as its own assistant turn. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR9 of the v1.5 train — the critique flow from
346:11571(benchmark submit) and346:12768(feedback + apply).benchmark:import, thenbenchmarks:analyzeso scoring context is fresh); the text field takes the "copy and paste a link" role — an http(s)-only submission fetches the post's video through the PR5benchmark:fromUrlpath instead of running a turn.applyCritiqueFixesstore action runs auto-tune withautotune:phasestreaming into a fresh assistant turn, flips the card'sappliedflag (persisted), and reloads the cut.markCritiqueApplied(session lib) + a fullapplyCritiqueFixesstore test (145 total).Renderer-only — HMR covers it.
Test plan
Made with Cursor