Skip to content

chore: patch direct dependency vulnerabilities #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thinkdj wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: patch direct dependency vulnerabilities #145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ ottabase/
## Prerequisites

- **Node.js**: `>=24.0.0`
- **pnpm**: `>=10.0.0`
- **pnpm**: `10.32.1`

Copilot AI Mar 25, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README now pins pnpm to an exact version, but the repo metadata still allows a broader range (engines.pnpm is >=10.0.0). To avoid confusing setup instructions, consider aligning these: either keep README as a minimum requirement (and rely on packageManager for the exact version), or update engines.pnpm to match the documented/pinned version. Also, corepack enable pnpm enables pnpm but doesn’t ensure the specific pnpm version is activated; consider documenting the Corepack step that activates the repo’s packageManager version explicitly.

Copilot uses AI. Check for mistakes.
- **Windows Users**: Ensure
[Visual C++ Redistributable](https://learn.microsoft.com/en-us/cpp/windows/latest-supported-vc-redist?view=msvc-170#latest-supported-redistributable-version)
is installed for builds to work correctly.
Expand All @@ -64,6 +64,7 @@ ottabase/

```bash
# Install
corepack enable pnpm

Copilot AI Mar 25, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README now pins pnpm to an exact version, but the repo metadata still allows a broader range (engines.pnpm is >=10.0.0). To avoid confusing setup instructions, consider aligning these: either keep README as a minimum requirement (and rely on packageManager for the exact version), or update engines.pnpm to match the documented/pinned version. Also, corepack enable pnpm enables pnpm but doesn’t ensure the specific pnpm version is activated; consider documenting the Corepack step that activates the repo’s packageManager version explicitly.

Copilot uses AI. Check for mistakes.
pnpm install

# Build packages (required first time)
Expand Down
3 changes: 2 additions & 1 deletion apps/ottabase-template-app-nextjs-homepage/app/theme-demo/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import Link from 'next/link';

export default function ThemeDemo() {
const { config } = useBrand();
const themeName = config?.brandName || 'Current theme';
Comment on lines 10 to +11

Copilot AI Mar 25, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using || will replace valid falsy values (e.g., an intentionally-empty brandName of "") with the fallback. If the intent is only to fall back when the value is null/undefined, prefer nullish coalescing (??) or compute after the if (!config) guard and use config.brandName with ??.

Copilot uses AI. Check for mistakes.

if (!config) {
return <div>Loading theme...</div>;
Expand All @@ -31,7 +32,7 @@ export default function ThemeDemo() {
</Button>
</div>

<h1 className="font-heading text-4xl font-bold text-foreground">Theme Demo: {config.themeBase}</h1>
<h1 className="font-heading text-4xl font-bold text-foreground">Theme Demo: {themeName}</h1>

Copilot AI Mar 25, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using || will replace valid falsy values (e.g., an intentionally-empty brandName of "") with the fallback. If the intent is only to fall back when the value is null/undefined, prefer nullish coalescing (??) or compute after the if (!config) guard and use config.brandName with ??.

Copilot uses AI. Check for mistakes.

{/* Typography Demo */}
<section className="space-y-4 rounded-lg border border-border bg-card p-6">
Expand Down
6 changes: 3 additions & 3 deletions apps/ottabase-template-app-nextjs-homepage/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"class-variance-authority": "catalog:",
"clsx": "catalog:",
"lucide-react": "catalog:",
"next": "^16.1.1",
"next": "^16.2.1",
"next-themes": "catalog:",
"react": "catalog:",
"react-dom": "catalog:",
Expand All @@ -38,7 +38,7 @@
},
"devDependencies": {
"@cloudflare/workers-types": "catalog:",
"@opennextjs/cloudflare": "^1.11.0",
"@opennextjs/cloudflare": "^1.17.3",
"@ottabase/ui-tailwind": "workspace:*",
"@tailwindcss/forms": "catalog:",
"@tailwindcss/typography": "catalog:",
Expand All @@ -47,7 +47,7 @@
"@types/react-dom": "catalog:",
"autoprefixer": "catalog:",
"eslint": "catalog:",
"eslint-config-next": "^16.1.1",
"eslint-config-next": "^16.2.1",
"postcss": "catalog:",
"postcss-preset-env": "catalog:",
"tailwindcss": "catalog:",
Expand Down
1 change: 0 additions & 1 deletion apps/ottabase-template-app-tanstack/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@
"@cloudflare/workers-types": "catalog:",
"@ottabase/ui-tailwind": "workspace:*",
"@tanstack/react-query-devtools": "catalog:",
"@types/diff": "^8.0.0",
"@types/node": "catalog:",
"@types/nodemailer": "catalog:",
"@types/react": "catalog:",
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@
"jsdom": "^27.4.0",
"lint-staged": "catalog:",
"next-themes": "catalog:",
"pnpm": "10.27.0",
"pnpm": "10.32.1",
"postcss-loader": "catalog:",
"prettier": "catalog:",
"rimraf": "catalog:",
Expand All @@ -83,7 +83,7 @@
"vitest": "catalog:",
"webpack": "^5.104.1"
},
"packageManager": "pnpm@10.27.0",
"packageManager": "pnpm@10.32.1",
"engines": {
"node": ">=24.0.0",
"pnpm": ">=10.0.0"
Expand Down
Loading
Loading