fix: repair broken CI workflow and quality checks - #1
Merged
Merged
Conversation
Simplify cluster package imports, tighten SignalValue/None guards in the Civic10 encoder and lineage analysis, and remove unused type ignores. Co-authored-by: Matthew <matthewlooney5@gmail.com>
The workflow failed to parse because a multiline python -c step had an unindented line. Also apply ruff format/lint fixes, align evidence schemas with Confidence/SourceType, allowlist the synthetic candump fixture, and configure mypy overrides for optional PySide6/python-can imports. Co-authored-by: Matthew <matthewlooney5@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI on
mainnever ran jobs because.github/workflows/ci.ymlwas invalid YAML (an unindented line in a multilinepython -cstep). This PR fixes that and the quality failures that appear once the workflow can parse.Changes
canimportstests/fixtures/synthetic_candump.logand allowlist it in.gitignoreSourceTypewith values used in protocol catalogs (DOCUMENTED,RESEARCH_NOTE, etc.)tools/generate_docs.pyEvidence / safety
SYNTHETICTest plan
ruff check/ruff format --checkmypy opendashcanpytest(106 passed, 6 skipped)python tools/validate_evidence.py