29-s3-followup: collectible group edit is one undo step (setNodesData) - #7
Merged
Merged
Conversation
…n, radius on the form - the manager redraws on api.flow.onChange + api.game.onChange (core PR #224) instead of a 500ms interval; a clock runs only while a respawn countdown is on screen, an older recipe chain's latch value is re-read once 300ms after a change, and the panel re-reads on pointerenter (a rename in the viewport is not an event) - the recipe asks api.flow.freeRegion once per pair, so pairs stack under whatever is in the graph instead of on a row derived from collectibles.length (DEVX #16) - both seams are FEATURE-DETECTED: on a 1.14.0-shaped api the module keeps its 500ms poll and fixed rows (asserted by registering the same source against an api with the seams removed) - S4 plan items: the touch radius is on the form (disabled with the reason under a click trigger); a group header whose counts include older recipe chains says "+N older recipe chain(s) counted here (edit in the node editor)" - version 1.1.0 (manifest, module, index.json); DEVX-REQUESTS #16/#17 marked SHIPPED - flights: module-collectible 130/130 (+1 legacy-copy check; the R29 checks moved to their own file because the main flight sits near the runner's 8-minute cap — it was killed at 480s with them in), new module-collectible-signals 14/14, against core feat/29-sdk-polish on :5213 - counterfactual: forcing the poll branch -> "redraws on change signals" and "an idle manager touches nothing" red (12 DOM mutations in 2.5s) - S3 measured here too: one group press over 60 members = 60 nodedata messages, 7.1ms, 0 undo entries -> the batch seam stays held (see core PR #224) Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…tNodesData - bulkApply collects the members that differ and hands them to core's api.flow.setNodesData (core R29 S3b) in one call: one Ctrl+Z undoes the whole group change. Feature-detected - on a core without it the module writes per node exactly as before. Members that already agree are still skipped; the wire is unchanged (one nodedata per member). - README: the group-edit paragraph and the toolbox row say so. v1.1.1. - module-collectible-signals section 12: a 20-member group press is ONE flownodes data entry of 20 items attributed to `collectible`, replicates to the peer, one undo restores all twenty on both peers; the 1.14-shaped api (setNodesData removed) still flips the whole group per node. - Counterfactual: batch call disabled (forced fallback) -> 3 red (17 -> 37 entries, one undo restored one member). - module-collectible-signals 21/21 (base 14/14); module-collectible 130/130 (base 130), against core feat/29-s3-followup on :5213. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Roadmap 29, lane
29-s3-followup, scope 3 ofplans/core/pending/module-node-data-undo-and-batch.md.Stacked on #4 (
feat/29-sdk-collectible, S4) — merge #4 first. Needs core theprototype-app/core#227 (and #224) for the batched path; without them the module falls back to per-node writes.What landed
25ccc1acollectible's group edit (bulkApply) hands the members that differ toapi.flow.setNodesDatain one call → one Ctrl+Z undoes a whole group change. Feature-detected; an older core writes per node as before. Wire unchanged (onenodedataper member). README updated; v1.1.1 (manifest, module.js, index.json).flownodesdata entry of 20 items attributed tocollectible, replicated, one undo restores all twenty on both peers; the 1.14-shaped api (nosetNodesData) still flips the whole group.Flights (against core
feat/29-s3-followupon :5213)Counterfactual: batch call disabled → 3 red (17 → 37 entries; one undo restored one member).
🤖 Generated with Claude Code