Repository navigation
Conversation
Owner
|
Thank you for your contribution! Ping me when it's ready for review, and I'll make sure it's included in the next major release which will also include many GUI fixes as well as the experimental native renderer! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
The macOS v0.3.0 launcher exits before showing setup because
libjxl.0.11.dylibimports@rpath/libjxl_cms.0.11.dylib, which the archive omits. The existing bundler skips relative imports, so this passes the final absolute-Homebrew-path check.Fixes #11.
@rpath,@loader_path, and@executable_pathimports recursively. Preserve original library locations and inherited runpaths until dependencies have been found, then flatten and rewrite the staged graph.Project8Recompplayer entry.Python is needed for packaging only, not by players. No dependency versions, game runtime code, or UI controls change.
Validation
git diff --checkpass.A complete game release rebuild and gameplay are not tested here; the fixtures and launcher build need no disc data. The smoke test checks loading, not interactive UI behavior.
Checklist
default.xex, decrypted intermediates, platform keys, or generated translation units.tools/check_no_game_content.shpasses.ctestpasses.