Repository navigation
Version update to 1.6.12 - #145
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The lockfile version is stale, and the changelog advertises fixes not included in the reviewed changes.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Updates eStore release metadata and documents version 1.6.12.
Changes:
- Bumps theme and package versions.
- Updates WordPress compatibility metadata to 7.1.
- Adds the 1.6.12 changelog entry.
| File | Summary |
|---|---|
style.css |
Updates theme version and WordPress compatibility. |
sass/style.scss |
Synchronizes source metadata. |
readme.txt |
Adds release notes. |
package.json |
Updates package version. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| "name": "estore", | ||
| "title": "eStore", | ||
| "version": "1.6.", | ||
| "version": "1.6.12", |
wp_get_attachment_image_src() returns false for an item with no featured image, and the widgets read [0] from it before checking, which is a warning on PHP 8 ('Trying to access array offset on false'). They now check with empty(), so the existing placeholder image is used without the warning.
Verified: php -l, and on PHP 8.4 a front-end scan of the shop, cart, checkout, home, search and 404 pages went from the warning on every page that renders the product grid to none.
Widget update() methods read $new_instance keys directly, so saving a widget without every field raises 'Undefined array key' warnings on PHP 8 and a strip_tags(null) deprecation on 8.1. This happens whenever a partial save arrives (REST, WP-CLI), and in Pro on every save of a license-locked widget, because the lock replaces the form and no fields are posted. update() now merges the input with an empty default for each key it reads; checkbox keys that are only tested with isset() are left out so unticked boxes still save as 0. Verified: php -l on every widget file.
estore_template_loop_product_thumbnail() read $image_url[0] without checking it. has_post_thumbnail() stays true for a featured image whose file was deleted, but wp_get_attachment_image_src() then returns false, so the read raised a PHP 8 warning. The zoom link is now only output when there is an image URL, and the URL is escaped. Verified: php -l.
…on template The WooCommerce Category Collection template printed the category name and description unescaped, so markup stored in either was output as-is, and an unguarded get_term_link() result was passed to esc_url(). The template now matches the Pro version: esc_html() for the name, wp_kses_post() for the description (the function WooCommerce uses for its own category description), and the links are skipped when the term link is an error. Verified: php -l.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
= Version 1.6.12 - 2026-10-07 =