Repository navigation
ST-958 Fix - Deprecated wp_script_add_data() conditional notice on wp 6.9+ - #57
Merged
deepench merged 1 commit intoOct 1, 2026
Conversation
Only add the 'conditional' script data for html5shiv on WP < 6.9, since core dropped IE conditional comment output in 6.9 and the argument is deprecated there.
deepench
deleted the
ST-958-accelerate-theme-deprecated-warnings-on-php-8-4-and-wordpress-7
branch
October 1, 2026 03:26
Contributor
|
@jenisha00 heads-up: with the condition skipped on WP 6.9+, the html5shiv enqueue has no IE gate any more, so #86 fixes this the way Spacious and Radiate did (empty |
rajatgautam755421
added a commit
that referenced
this pull request
Oct 2, 2026
…merged Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
iamprazol
pushed a commit
that referenced
this pull request
Oct 5, 2026
… a deprecation notice (#86) * Fix - Stop registering the IE-conditional html5shiv script that fires a deprecation notice wp_script_add_data( 'html5shiv', 'conditional', 'lte IE 8' ) fires a deprecation notice on every page since WordPress 6.9, and the script is no longer printed at all. Replaced with an empty html5shiv handle, as in Spacious and Radiate, so scripts that depend on it still load. js/html5shiv.js stays so direct URLs don't 404. Same fix as themegrill/accelerate-pro#21. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * Test - Tag the PHP-notices spec with the area inc/functions.php maps to, and assert a 200 The area decides whether the suite runs this spec for a change to inc/functions.php; it was tagged with an area that file doesn't map to. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * Test - Also assert html5shiv.js is no longer printed now that #57 is merged Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.