Skip to content

fix of infinite loop browser/node detection #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fleedoJ wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix of infinite loop browser/node detection #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,12 +125,21 @@ export function keywordFilter(str: string, keywords: string[]): boolean {
return true;
}

// Precompute environment flags to avoid recursion when both globals exist (e.g. Electron renderer).
const hasWindow = typeof window !== "undefined";
const hasProcess = typeof process !== "undefined";
const hasElectron = hasProcess && !!(process as any).versions?.electron;

export function isBrowser(): boolean {
return typeof window !== 'undefined' && !isNode();
return hasWindow && !hasElectron;
}

export function isNode(): boolean {
return typeof process !== 'undefined' && !isBrowser();
return hasProcess && !hasElectron;
}

export function isElectron(): boolean {
return hasElectron;
}

export function apiKeys() {
Expand Down Expand Up @@ -180,4 +189,4 @@ export function join(...pathSegments: string[]): string {

if (parts[0] === "") newParts.unshift("");
return newParts.join("/") || (newParts.length ? "/" : ".");
}
}