Skip to content

Add XFS ficlone detection and basic filesystem test#542

Open
andy5995 wants to merge 3 commits into
masterfrom
add-xfs-test
Open

Add XFS ficlone detection and basic filesystem test#542
andy5995 wants to merge 3 commits into
masterfrom
add-xfs-test

Conversation

@andy5995
Copy link
Copy Markdown
Member

@andy5995 andy5995 commented May 5, 2026

  • Detect XFS via XFS_SUPER_MAGIC in is_ficlone_fs()
  • Add test image, test script, config, and CI cache/download steps
  • Update man page NOTES section to include XFS

- Detect XFS via XFS_SUPER_MAGIC in is_ficlone_fs()
- Add test image, test script, config, and CI cache/download steps
- Update man page NOTES section to include XFS

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@andy5995 andy5995 added this to the v0.10.0 milestone May 5, 2026
@andy5995 andy5995 marked this pull request as draft May 5, 2026 18:55
- is_ficlone_fs: use lstat+parent-dir statfs for symlinks so the
  symlink inode's filesystem is checked rather than the target's;
  also use arg (trailing-slash stripped) instead of argv[file_arg]
- is_ficlone_fs: cache result per file before the waste loop to
  avoid redundant statfs calls on bulk removals
- do_ficlone: copy extended attributes after a successful FICLONE
- ficlone cross-device failure: try next waste dir on any error
  instead of calling exit() for non-EXDEV errno values
- test_btrfs_clone: add dangling-symlink and xattr preservation tests
- ci: install attr package for setfattr/getfattr in xattr tests

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@andy5995 andy5995 marked this pull request as ready for review May 5, 2026 19:27
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant