Debian 13 by evgeni · Pull Request #235 · theforeman/foremanctl

evgeni · 2025-09-19T07:03:23Z

No description provided.

ekohl · 2025-09-23T09:16:27Z

  ansible.builtin.file:
-    path: /etc/httpd/conf.d/welcome.conf
+    path: "{{ httpd_conf_path }}/welcome.conf"
    state: absent


A thought for upgrades and not necessary for this PR: RPM will place this file back. Should we ensure it's empty instead?

Or just deploy on Debian, where the package manager is actually sane and respects the choices of the admin ;)

Or just put it all in a container /me ducks

evgeni · 2025-09-23T12:04:41Z

+    - ansible_selinux.status == 'enabled'
+
+- name: Enable required modules
+  community.general.apache2_module:


I don't like pulling in community.general here, but this is something we'd have to consider anyway.
In the Puppet installer, we run with apache::default_mods: false, which wipes all enabled modules and then we enable the ones we need.
We didn't port that detail over to foremanctl, and rely on the OS to enable those modules for us. But it also most probably enables things we do not want.

We may also want to enable the event MPM in a similar way.

I don't like pulling in community.general here, but this is something we'd have to consider anyway.

May I ask why it is bad to use community.general?

Mostly because it's a dependency we don't yet have

It also mentions compatibility:

This does not work on RedHat-based distributions. It does work on Debian- and SuSE-based distributions. Whether it works on others depend on whether the C(a2enmod) and C(a2dismod) tools are available or not.

So configuring Apache with Ansible is certainly worse than what we had with our Puppet module.

evgeni · 2026-03-02T14:05:01Z

I've split out the EL10 base of this PR into #393 so we can review that independently of the (heavier) Debian changes

jakduch · 2026-03-28T19:06:10Z

Hi @evgeni, great work on the Debian 13 support! I built on top of your branch and found a few things that could be improved. I created PR #427 targeting your debian branch with the following commits:

Bug fixes:

Fix duplicate conf.d/ in foreman-vhost.conf.j2 — httpd_conf_path already contains conf.d (RedHat) / conf-enabled (Debian), so the extra conf.d/ segment in the IncludeOptional path on line 5 results in an invalid path. The SSL vhost was already correct.
Fix spurious space in cleanup.yml line 4: {{ httpd_conf_path}} /05- should be {{ httpd_conf_path }}/05-

Debian adaptations:

Make httpd IPA external auth OS-aware — use libapache2-mod-* packages and community.general.apache2_module (a2enmod/a2dismod) on Debian instead of manual LoadModule conf files
Add OS-specific vars for hammer role (ruby-hammer-cli-* on Debian vs rubygem-hammer_cli_* on RedHat) and load them via include_vars
Add Foreman repository setup for Debian in the development playbook (using theforeman.operations.foreman_repositories)
Enable hammer deployment on Debian in CI (remove the centos-only condition)

Feel free to cherry-pick any of these commits directly into your branch, or merge #427 if you prefer. Happy to adjust anything!

evgeni · 2026-06-03T12:40:55Z

Thanks, I've picked up the bugfixes, will have a look at the enhancements later.

bochi · 2026-06-24T16:09:14Z

works very well, tested on Ubuntu 26 and Debian 13!

coderabbitai · 2026-06-24T17:03:16Z

Caution

Review failed

An error occurred during the review process. Please try again later.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch debian

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

This needs Podman 5.6, while Debian ships 5.4. podman-container-tools/podman@439448c

evgeni · 2026-06-25T08:30:36Z

-    name: httpd
+    name: "{{ httpd_service }}"
    state: started
    enabled: true


Services are enabled by default on Debian, so this line doesn't trigger an "enable" action, and thus the "Add httpd to foreman.target" is never applied (as systemctl enable is where the symlinks are created for the targets). 😿

evgeni force-pushed the debian branch 6 times, most recently from 3ef53b1 to 834aafa Compare September 19, 2025 13:20

evgeni changed the title ~~CentOS 10 and Debian 13~~ CentOS Stream 10 Sep 19, 2025

evgeni force-pushed the debian branch from 834aafa to 2361fbb Compare September 19, 2025 14:11

evgeni commented Sep 20, 2025

View reviewed changes

Comment thread development/playbooks/setup-repositories/setup-repositories.yaml

evgeni force-pushed the debian branch from 2361fbb to 5fd6f44 Compare September 20, 2025 08:21

ekohl reviewed Sep 20, 2025

View reviewed changes

Comment thread development/playbooks/setup-repositories/setup-repositories.yaml

evgeni force-pushed the debian branch 8 times, most recently from fbb356d to 0f719e0 Compare September 23, 2025 09:09

ekohl reviewed Sep 23, 2025

View reviewed changes

evgeni force-pushed the debian branch 3 times, most recently from 50dede3 to 49d9e3f Compare September 23, 2025 10:39

evgeni commented Sep 23, 2025

View reviewed changes

evgeni changed the title ~~CentOS Stream 10~~ CentOS Stream 10 (and Debian 13?) Sep 23, 2025

ekohl reviewed Sep 25, 2025

View reviewed changes

Comment thread src/roles/httpd/tasks/main.yml Outdated

evgeni force-pushed the debian branch 3 times, most recently from 42c388f to 1660537 Compare October 16, 2025 07:48

evgeni mentioned this pull request Oct 27, 2025

Add Foreman development environment #259

Merged

evgeni force-pushed the debian branch from 7eb4087 to a9bf7d7 Compare March 2, 2026 14:02

evgeni force-pushed the debian branch from a9bf7d7 to 8ed2fe5 Compare March 3, 2026 06:47

evgeni changed the title ~~CentOS Stream 10 (and Debian 13?)~~ Debian 13 Mar 3, 2026

jakduch mentioned this pull request Mar 28, 2026

Improve Debian 13 support: hammer, IPA auth, bug fixes #427

Open

evgeni force-pushed the debian branch 3 times, most recently from 9b43c7d to 5fe9467 Compare June 3, 2026 12:40

evgeni force-pushed the debian branch from 5fe9467 to feb639e Compare June 3, 2026 13:49

evgeni added 4 commits June 24, 2026 18:39

add Debian 13 to the mix

94bdba8

Refresh package cache on Debian during setup-repositories

2eaa886

Debian needs to install netavark explicitly

43136b1

python3-libsemanage is called python3-semanage on Debian

2127171

evgeni force-pushed the debian branch from feb639e to 595ec17 Compare June 24, 2026 16:39

evgeni force-pushed the debian branch 5 times, most recently from 626050a to a757829 Compare June 25, 2026 05:49

evgeni added 5 commits June 25, 2026 09:20

make httpd role work on Debian

bd9d7f9

skip hammer on Debian

b5d0258

disable synced folder, takes time, we don't use it

9f0d562

Debian doesn't ship curl in their box

d47f01a

Only set Policy on non-Debian

a7faf2e

This needs Podman 5.6, while Debian ships 5.4. podman-container-tools/podman@439448c

evgeni force-pushed the debian branch from a757829 to a7faf2e Compare June 25, 2026 07:21

evgeni commented Jun 25, 2026

View reviewed changes

Uh oh!

Conversation

evgeni commented Sep 19, 2025

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

evgeni commented Mar 2, 2026

Uh oh!

jakduch commented Mar 28, 2026

Uh oh!

evgeni commented Jun 3, 2026

Uh oh!

bochi commented Jun 24, 2026

Uh oh!

coderabbitai Bot commented Jun 24, 2026

Review failed

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants