Fixes #39467 - Replace enzyme test in ConfigReports with RTL#11050
Open
kfamilonidis wants to merge 1 commit into
Open
Fixes #39467 - Replace enzyme test in ConfigReports with RTL#11050kfamilonidis wants to merge 1 commit into
kfamilonidis wants to merge 1 commit into
Conversation
kfamilonidis
force-pushed
the
pf5-config-reports
branch
4 times, most recently
from
June 30, 2026 11:09
8c0c716 to
d03ed6b
Compare
Contributor
SummarySolid migration from an Suggestions (should fix)
Nice to have (optional)
Checklist gaps
|
kfamilonidis
force-pushed
the
pf5-config-reports
branch
2 times, most recently
from
July 14, 2026 13:48
bb23810 to
572fa3c
Compare
Contributor
Author
|
@Lukshio I added a NOTE comment above the class-based assertions explaining why they're coupled to CSS classes. Added, scoped to each chart's own card:
Made each 10 explicit about which row/footer it belongs to and won't break if a third 10 is added elsewhere. |
kfamilonidis
force-pushed
the
pf5-config-reports
branch
from
July 14, 2026 16:34
572fa3c to
eecab03
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #39467: Replace enzyme test in ConfigReports with RTL