Skip to content

correctly encode content uploads as multipart/form-data#1871

Draft
evgeni wants to merge 1 commit into
developfrom
multipart/form-data
Draft

correctly encode content uploads as multipart/form-data#1871
evgeni wants to merge 1 commit into
developfrom
multipart/form-data

Conversation

@evgeni

@evgeni evgeni commented Jun 6, 2025

Copy link
Copy Markdown
Member

before this, they were encoded as application/x-www-form-urlencoded, and
while this technically works, it makes the request 2-3× larger,
sometimes hitting limits in Rack/Rails.

Fixes: #1862

before this, they were encoded as application/x-www-form-urlencoded, and
while this technically works, it makes the request 2-3× larger,
sometimes hitting limits in Rack/Rails.

Fixes: #1862
@evgeni

evgeni commented Jun 6, 2025

Copy link
Copy Markdown
Member Author

interestingly, the uploaded data is corrupt 🙈

@evgeni

evgeni commented Jun 6, 2025

Copy link
Copy Markdown
Member Author

@evgeni

evgeni commented Jun 6, 2025

Copy link
Copy Markdown
Member Author

As this seems to require more work, let's apply a workaround for now: #1872

@ekohl

ekohl commented Apr 30, 2026

Copy link
Copy Markdown
Member

@evgeni now that Katello/katello#11408 is fixed, can this progress?

@evgeni

evgeni commented Apr 30, 2026

Copy link
Copy Markdown
Member Author

Technically, yes.
It'd make the code incompatible with older releases (unless we do some wild if/else based on version), so I've been putting it off for now.
Is there any pressure to get this in?

@ekohl

ekohl commented May 4, 2026

Copy link
Copy Markdown
Member

I came across this in https://redhat.atlassian.net/browse/SAT-41766 which mentioned there was only a workaround in place. But you're right that not breaking compatibility with versions prior to Katello 4.18 is also a valuable thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[content_upload] Error while performing update on content_uploads

2 participants