Jointly Cartesian Families - #481
Merged
Merged
Conversation
Member
New pages
Changed pages
|
plt-amy
previously approved these changes
Apr 7, 2025
Collaborator
Author
|
Did another prose check and found some typos, but should be good to go now! |
plt-amy
approved these changes
Apr 8, 2025
4e554c4c
pushed a commit
to 4e554c4c/1lab
that referenced
this pull request
Apr 18, 2025
# Description This PR defines jointly cartesian families, which paves the way for the correct way to handle the1lab#424. Right now the prose is a bit sparse, as many of the good examples require us to develop point-set topology, which is exactly what I added this to do! Some of the names for the cancellation lemmas are also a bit brutal; suggestions are very much appreciated! I've also done a bit of cleanup on some proofs in `Cat.Displayed.Cartesian`; I needed to generalize a bunch of these, so figured now would be a good of a time as any. ## Checklist Before submitting a merge request, please check the items below: - [x] I've read [the contributing guidelines](https://github.com/plt-amy/1lab/blob/main/CONTRIBUTING.md). - [x] The imports of new modules have been sorted with `support/sort-imports.hs` (or `nix run --experimental-features nix-command -f . sort-imports`). - [x] All new code blocks have "agda" as their language. If your change affects many files without adding substantial content, and you don't want your name to appear on those pages (for example, treewide refactorings or reformattings), start the commit message and PR title with `chore:`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR defines jointly cartesian families, which paves the way for the correct way to handle #424. Right now the prose
is a bit sparse, as many of the good examples require us to develop point-set topology, which is exactly what I added this to do! Some of the names for the cancellation lemmas are also a bit brutal; suggestions are very much appreciated!
I've also done a bit of cleanup on some proofs in
Cat.Displayed.Cartesian; I needed to generalize a bunch of these, so figured now would be a good of a time as any.Checklist
Before submitting a merge request, please check the items below:
support/sort-imports.hs(ornix run --experimental-features nix-command -f . sort-imports).If your change affects many files without adding substantial content, and
you don't want your name to appear on those pages (for example, treewide
refactorings or reformattings), start the commit message and PR title with
chore:.