dedup: fix stale valueType in boundedSeriesIterator.Next() - #9028
Open
anusha19murthy wants to merge 2 commits into
Open
anusha19murthy wants to merge 2 commits into
anusha19murthy wants to merge 2 commits into
Conversation
GiedriusS
reviewed
Sep 16, 2026
GiedriusS
left a comment
Member
There was a problem hiding this comment.
Why not add mixed type support to type sample?
anusha19murthy
force-pushed
the
fix/bounded-iterator-stale-valuetype
branch
from
September 17, 2026 12:11
2456510 to
869dd7c
Compare
Contributor
Author
|
I've added the required changes |
Member
|
Linter errors seem related |
anusha19murthy
force-pushed
the
fix/bounded-iterator-stale-valuetype
branch
from
September 19, 2026 05:01
869dd7c to
6fa670e
Compare
Signed-off-by: anusha19murthy <anusha19murthy@gmail.com>
anusha19murthy
force-pushed
the
fix/bounded-iterator-stale-valuetype
branch
from
September 19, 2026 05:10
6fa670e to
871c6a7
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9028 +/- ##
==========================================
- Coverage 64.55% 64.54% -0.02%
==========================================
Files 289 289
Lines 37412 37413 +1
==========================================
- Hits 24153 24149 -4
- Misses 11158 11164 +6
+ Partials 2101 2100 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
boundedSeriesIterator.Next()returns a stalevalueTypewhen it seeks past samples beforemint.When the first sample falls before
mint, the iterator seeks forward correctly but still returns thevalueTypefrom the original sample (before the seek) instead of the one it landed on. If a series changes from float to histogram right at the query boundary, we end up returningValFloatwhen the actual sample is a histogram.The fix
I capture the return value of
Seek()back intovalueTypeso the caller gets the correct type:This was introduced in
789046ad1when the return type changed frombooltochunkenc.ValueType— the old bool version couldn't have this mismatch.Tests
Added
TestBoundedSeriesIteratorNextValueTypewith amixedTypeIteratorhelper that supports interleaved float/histogram samples. Covers: