ui: honor the persisted Use Partial Response checkbox value - #9024
Open
shashankvarma499 wants to merge 2 commits into
Open
shashankvarma499 wants to merge 2 commits into
shashankvarma499 wants to merge 2 commits into
Conversation
The query panel forced usePartialResponse to true whenever the localStorage key existed, and the change handler overrode an uncheck whenever "true" was stored, so the checkbox could never be turned off. Restore the persisted boolean when the panel mounts and drop the forced override, so unchecking it survives a reload. Fixes thanos-io#8993 Signed-off-by: Shashank Varma <324153016+shashankvarma499@users.noreply.github.com>
Signed-off-by: Shashank Varma <324153016+shashankvarma499@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
The query panel could never keep the "Use Partial Response" checkbox unchecked:
Panel.componentDidMountchecked only for the presence of theusePartialResponselocalStorage key and then unconditionally forced the value totrue(in state, in the parent viaonUsePartialResponseChange, and back into localStorage), so a stored"false"was overwritten on the next mount.Panel.handleChangePartialResponseforcednewValueback totruewhenever the stored value was"true", so oncetruehad ever been persisted the checkbox could not be unchecked again.This restores the persisted boolean when the panel mounts and drops the forced override, so the checkbox reflects what the user last chose.
Fixes #8993
Verification
pnpm test src/pages/graph/Panel.test.tsxfrompkg/ui/react-app: 13 passed, including three new tests covering the persistence behaviour.Panel.tsxreverted).pnpm lint:ciandprettier --checkare clean on the touched files.