Skip to content

fix: SW-2094 default tab active state — white pill instead of blue#148

Merged
owilliams-tetrascience merged 1 commit into
mainfrom
SW-2094-tab-styling
Jun 24, 2026
Merged

fix: SW-2094 default tab active state — white pill instead of blue#148
owilliams-tetrascience merged 1 commit into
mainfrom
SW-2094-tab-styling

Conversation

@boramyi-ts

@boramyi-ts boramyi-ts commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Summary

SW-2094 — the horizontal default tabs used blue (bg-primary) for the active tab, which competed with primary action buttons. Change the active tab to a white pill with a shadow so selection reads clearly without the blue.

Change

tabs.tsx:68 — default-variant active tab:

- data-active:bg-primary  data-active:text-primary-foreground  …  dark:data-active:bg-primary  …text-primary-foreground
+ data-active:bg-card      data-active:text-foreground          …  dark:data-active:bg-card      …text-foreground

Active tab is now bg-card + text-foreground + the existing shadow-sm. The grey track, inactive tabs, and the line variant (blue underline) are unchanged.

Before / after

Before (blue) After (white pill)
Light before light after light
Dark before dark after dark

In dark mode the tokens adapt: bg-card → the elevated dark surface (#313036) on the darker track, text-foreground → light — the same "elevated, clearly selected" treatment as light, without a harsh pure-white pill.

yarn lint + yarn typecheck pass.

🤖 Generated with Claude Code

The horizontal default tabs used bg-primary (blue) for the active tab,
which competed with primary action buttons. Switch the active tab to a
white bg-card pill with foreground text and the existing shadow-sm, so
selection reads as an elevated segmented-control tab. bg-card and
text-foreground adapt to dark mode (elevated surface + light text). The
line variant and inactive states are unchanged.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@boramyi-ts boramyi-ts requested review from a team as code owners June 23, 2026 20:13
@vercel

vercel Bot commented Jun 23, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
ts-lib-ui-kit-storybook Ignored Ignored Jun 23, 2026 8:14pm

Request Review

@boramyi-ts boramyi-ts temporarily deployed to artifactory-prod June 23, 2026 20:14 — with GitHub Actions Inactive
@github-actions

Copy link
Copy Markdown

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 94.74% (🎯 83%)
🟰 ±0%
20627 / 21770
🟢 Statements 94.74% (🎯 83%)
🟰 ±0%
20627 / 21770
🟢 Functions 93.58% (🎯 74%)
🟰 ±0%
919 / 982
🟢 Branches 88.74% (🎯 81%)
🟰 ±0%
3770 / 4248
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/components/ui/tabs.tsx 100%
🟰 ±0%
100%
🟰 ±0%
100%
🟰 ±0%
100%
🟰 ±0%
Generated in workflow #817 for commit 3dd21d6 by the Vitest Coverage Report Action

@owilliams-tetrascience owilliams-tetrascience merged commit d90c397 into main Jun 24, 2026
14 checks passed
@owilliams-tetrascience owilliams-tetrascience deleted the SW-2094-tab-styling branch June 24, 2026 14:26
@blee-tetrascience

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 0.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants