Component examples#3
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds example Playwright “component” helpers and accompanying check specs for common Testspace flows (login, create project, delete project), plus repository guidance for reliably interacting with Testspace’s AJAX-driven menus/dialogs.
Changes:
- Added
newProjectanddelProjectcomponent implementations for creating/deleting projects. - Added component check specs (
login,newProject,delProject) that exercise these components end-to-end. - Added
.github/copilot-instructions.mddocumenting stable interaction patterns for DETAILS-based row menus and overmind confirmation dialogs.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/components/newproject-component.js | New component helper for creating a standalone project via the New Project dialog. |
| tests/components/login-component.js | Updates login component flow and navigation comments; adds an unused import. |
| tests/components/delproject-component.js | New component helper for deleting a project using row menu + confirmation dialog patterns. |
| tests/components/checks/newproject.spec.js | New spec chaining login + create project + teardown delete project. |
| tests/components/checks/login.spec.js | Updates login spec to assert org header text; currently sets PASSWORD to empty string when missing. |
| tests/components/checks/delproject.spec.js | New spec chaining login + create project + delete project and asserting removal. |
| .github/copilot-instructions.md | New repo instructions documenting stable Playwright patterns for menus/dialogs in the AUT. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1
to
3
| const { expect } = require('@playwright/test'); | ||
|
|
||
| /** |
Comment on lines
+1
to
+3
| const { expect } = require('@playwright/test'); | ||
|
|
||
| /** |
| * 7. Click on "SUBMIT" | ||
| * 8. Submit new project dialog | ||
| */ | ||
| async function newprojectComponent(page) { |
| * 5. Click on "YES" | ||
| * 6. Submit form | ||
| */ | ||
| async function delprojectComponent(page) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example Testspace components: