Repository navigation
Add regression tests for mocking by package.json imports specifiers - #127
Merged
Merged
Conversation
To prevent a regression of #69. quibble.esm('#src/...') used to fail with ERR_PACKAGE_IMPORT_NOT_DEFINED because the dummy import() that finds a specifier's URL ran from quibble's own file, so Node resolved the specifier against quibble's package.json. Resolving non-relative specifiers from the caller (#123, 0.12.0) fixed this too, since `#` specifiers count as bare, but nothing tested it. The fixture is its own package with an `imports` field, and the calls to quibble come from a file inside it. The tests and quibble's lib directory share quibble's root package.json, so mapping the alias there would let 0.11.0 resolve it too and the tests would never fail. They do fail against 0.11.0's lib.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To prevent a regression of #69.
quibble.esm('#src/...') used to fail with ERR_PACKAGE_IMPORT_NOT_DEFINED because the dummy import() that finds a specifier's URL ran from quibble's own file, so Node resolved the specifier against quibble's package.json. Resolving non-relative specifiers from the caller (#123, 0.12.0) fixed this too, since
#specifiers count as bare, but nothing tested it.The fixture is its own package with an
importsfield, and the calls to quibble come from a file inside it. The tests and quibble's lib directory share quibble's root package.json, so mapping the alias there would let 0.11.0 resolve it too and the tests would never fail. They do fail against 0.11.0's lib.