Repository navigation
Install pnpm for testdouble.js's pnpm example in the integration job - #126
Merged
Merged
Conversation
testdouble.js now has an example project, examples/node-esm-pnpm, that its test suite installs with pnpm, so this job needs pnpm installed or it fails on every Node version. Install it the same way testdouble.js's CI does (pnpm 8 on Node 16, 9 on Node 18, latest otherwise). That example installs testdouble.js's dependencies itself, from testdouble.js's package.json, so `npm install --no-save` of this build only reached testdouble.js's root node_modules and the example quietly tested the published quibble. Point the checkout's quibble dependency at this build too, so both use it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
testdouble.js now has an example project, examples/node-esm-pnpm, that its test suite installs with pnpm, so this job needs pnpm installed or it fails on every Node version. Install it the same way testdouble.js's CI does (pnpm 8 on Node 16, 9 on Node 18, latest otherwise).