Upgrade Symphonia dependency to 0.6.0#157
Open
Eagisa wants to merge 4 commits into
Open
Conversation
tesselode
reviewed
Jun 7, 2026
Owner
|
Please run |
Author
|
Hey, I've addressed your feedback! Removed the UnexpectedEof special case in from_file.rs and ran rustfmt, turns out no changes were needed since the code was already following the project's formatting. All 98 tests pass. Let me know what you think! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated Symphonia from 0.5.4 to 0.6.0.
I tested the upgrade locally and did not encounter issues during playback testing.
I also ran
cargo test, and all tests passed successfully.Since there was a previous note mentioning that updating Symphonia would require investigation into the changes, I wanted to share this update in case it helps.