fix: preserve version strings with trailing zeros in JSON parsing#799
Open
AruneshDwivedi wants to merge 1 commit into
Open
fix: preserve version strings with trailing zeros in JSON parsing#799AruneshDwivedi wants to merge 1 commit into
AruneshDwivedi wants to merge 1 commit into
Conversation
Version strings like "1.30" were being truncated to "1.3" because json.loads() converts them to floats, losing the trailing zero. Changed json.loads(plan_lines) to json.loads(plan_lines, parse_float=str) to preserve the original string representation of numeric values. Fixes terraform-compliance#752 Signed-off-by: Arunesh Dwivedi <arunesh.devops@gmail.com>"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version strings like "1.30" were being truncated to "1.3" because
json.loads()converts them to floats, losing the trailing zero. This caused test failures when comparing version strings.Fixed by checking if the string looks like a version number before passing it through
json.loads(). If it matches a version pattern, keep it as a string.