Fix "Back Button Works Only on First Form When Multiple Forms Exist"#95
Conversation
Toflar
left a comment
There was a problem hiding this comment.
Hey, sorry for being late to the party. I was busy not being close to any computer 😉
Logic looks good to me but I think we don't need the BC handling for mp_form_pageswitch to be honest. This form field name shouldn't be added manually anywhere and if it was, I don't see why this would be API.
So I guess I'd just add a FormManager::getPageSwitchFormFieldName() and use this everywhere. What do you think?
|
I completely agree. I now implemented your suggestion using the additional FormManager method, removed the BC for the tests, and changed them. Can you verify that the tests still work? |
|
Thanks for the review! I implemented your suggestions :) |
|
Thank you @timlg07! ❤️ |
Closes #94