Fix incorrect step count in multi-step form#92
Merged
Conversation
Ensure the number of real form steps is calculated based on actual page breaks, not just the keys in $this->formFieldsPerStep. This resolves issues where additional wrappers (e.g., fieldsets) or misordered page breaks caused extra, invalid steps to be included.
Toflar
requested changes
May 19, 2025
Toflar
left a comment
Toflar
left a comment
Member
There was a problem hiding this comment.
Can't we fix it in a way that we can rely on $this->formFieldsPerStep containing the valid info? There are other methods relying on $this->formFieldsPerStep.
… step into the previous one
Toflar
reviewed
May 19, 2025
Co-authored-by: Yanick Witschi <yanick.witschi@terminal42.ch>
Toflar
requested changes
May 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure the number of real form steps is calculated based on actual page breaks, not just the keys in $this->formFieldsPerStep. This resolves issues where additional wrappers (e.g., fieldsets) or misordered page breaks caused extra, invalid steps to be included.