Modernize workflows, containers and rpm building#72
Open
StrongestNumber9 wants to merge 7 commits into
Open
Conversation
| <name>${project.groupId}-${project.artifactId}</name> | ||
| <version>${project.version}</version> | ||
| <release>${env.BUILD_ID}</release> | ||
| <license>Apache-1.1 AND Apache-2.0 AND LicenseRef-Callaway-BSD AND LicenseRef-Callaway-BSD-with-advertising AND GPL-1.0-or-later AND GPL-2.0-only AND LicenseRef-Callaway-GPLv2-with-exceptions AND IJG AND LicenseRef-Callaway-LGPLv2+ AND LicenseRef-Callaway-MIT AND MPL-2.0 AND LicenseRef-Callaway-Public-Domain AND W3C AND Zlib AND ISC AND FTL AND LicenseRef-RSA</license> |
Contributor
Author
There was a problem hiding this comment.
This needs to be checked, was taken as-is from example code
Comment on lines
+114
to
+116
| <defineStatement>_privatelibs libzip|libverify|libsyslookup|libsimdsort|libnio|libnet|libmanagement|libjsig|libjli|libjimage|libjava</defineStatement> | ||
| <defineStatement>__requires_exclude ^(%{_privatelibs})\.so</defineStatement> | ||
| <defineStatement>__provides_exclude ^(%{_privatelibs})\.so</defineStatement> |
Contributor
Author
There was a problem hiding this comment.
How were these library names determined, this was taken as-is from the example code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Manual testing shows it at least starts so I assume rest of the container is functional as well
Checklists
Testing
General
Assertions
Testing Data
Statements
Java
Other
Code Quality