updated icons in BottomNavigationBar#11
Open
oleksandrakovalova wants to merge 2 commits into
Open
Conversation
oleksandrakovalova
requested review from
ababicheva,
dativitad,
vyatsykiv and
yakivmospan
yakivmospan
reviewed
May 24, 2020
| import 'package:flutter_svg/flutter_svg.dart'; | ||
|
|
||
| class SvgIcon extends StatelessWidget { | ||
| const SvgIcon( |
Member
There was a problem hiding this comment.
Can we add default parameters to this constructor, so it will be possible to control color and size not only with theme:
const SvgIcon(
this.iconPath,
this.iconColor = null,
this.iconWidth = null,
this.iconHeight = null
);
Member
There was a problem hiding this comment.
Or let's keep it as is, but rename to something like BottomBarIcon and use it only there?
vyatsykiv
reviewed
May 25, 2020
Comment on lines
+12
to
+17
| Widget build(BuildContext context) { | ||
| return SvgPicture.asset( | ||
| iconPath, | ||
| color: IconTheme.of(context).color, | ||
| width: IconTheme.of(context).size, | ||
| height: IconTheme.of(context).size, |
Contributor
There was a problem hiding this comment.
Instead of 3 times call IconTheme.of(context) it would be nice to create local variable and retrieve properties from local object.
var iconThemeData = IconTheme.of(context);
And then in constructor - color = iconThemeData.color
yakivmospan
approved these changes
Jul 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.