Repository navigation
Release 7.8.4: undo message on kids' cards, adults in bin-day and shopping pickers - #1245
Merged
Merged
Conversation
On a child card or chore board with show_parent_actions: false (set by the dashboard wizard's "Hide parent buttons", on by default), a parent tapping a done chore was told "Only a parent can undo a completed chore." The refusal is intended, but the message blamed the parent's role. A parent now gets "Parent actions are turned off on this card..." with the way out; a child still gets the original message. - New string child.undo_parent_actions_hidden in all 11 locales - Wizard hint now says undo is switched off too - Docs: Dashboard Cards table, Ready-Made Dashboards, Troubleshooting - Guard test: any card that hides parent actions and refuses undo must also carry the parent-facing message Fixes #1243
…kers The backend accepts any profile for bin_day_children and shopping_jobs_children, but the Settings pickers only listed children, so a family could not run bin day first-come between a child and the parents, and saving Settings silently dropped adults stored another way. Both pickers now list adults after the children, marked with the Adult pill. None picked still means every child; an adult who takes the job auto-approves as usual (#1061). Fixes #1244
github-actions
Bot
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes, released as 7.8.4.
show_parent_actions: false(set by the dashboard wizard's "Hide parent buttons", on by default) a parent tapping a done chore got "Only a parent can undo a completed chore." The refusal is intended; the message blamed the parent's role. The child card and Chore Board now give a parent "Parent actions are turned off on this card…" with the way out; a child still gets the original message. New stringchild.undo_parent_actions_hiddenin all 11 locales, wizard hint updated, Manual: Dashboard Cards, Ready-Made Dashboards, Troubleshooting. Guard test fails any card that hides parent actions and refuses undo without the parent-facing message.bin_day_children/shopping_jobs_children, but the Settings pickers listed only children, so a stored adult was dropped on the next Settings save. Both pickers now list adults after the children with the Adult pill. None picked still means every child.Tested on ha-dev with the release tree routed in via browserless: child card and Chore Board refusal text for an admin with
show_parent_actions: false(child wording unchanged); bin-day and shopping pickers at 1400px and 375px with an adult profile, picked state kept. pytest 4560 passed, node 2185 passed, lint, translations, data files, locale bundles, manual check all green.Fixes #1243
Fixes #1244