Skip to content

Add counter for unaccessed failed promise warnings - #3141

Open
yeomin4242 wants to merge 1 commit into
temporalio:mainfrom
yeomin4242:fix/issue-2538
Open

yeomin4242 wants to merge 1 commit into
temporalio:mainfrom
yeomin4242:fix/issue-2538

Conversation

@yeomin4242

Copy link
Copy Markdown

What changed

Add temporal_workflow_unaccessed_failed_promise, incremented once for each failed Promise reported by the existing unaccessed-promise warning during runner cleanup. Document the metric and add a changelog entry.

The counter follows the existing warning path, including cache eviction and Worker shutdown. Replay-time increments are suppressed by the existing metrics scope; another runner may report the same failure again.

Closes #2538.

@CLAassistant

CLAassistant commented Oct 11, 2026 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@yeomin4242
yeomin4242 marked this pull request as ready for review October 11, 2026 14:28
@yeomin4242
yeomin4242 requested a review from a team as a code owner October 11, 2026 14:28
@Quinn-With-Two-Ns

Copy link
Copy Markdown
Contributor

Thank you for the contribution, Just to be transparent we have not decided if we even want #2538 , how we want to support it and how it would effect other SDKs. These are things we need to discuss first before we would review this particular PR so we may not be able to review this PR immediately.

Is this a feature you would personally want or did you just want to contribute to the Java SDK?

@Quinn-With-Two-Ns Quinn-With-Two-Ns self-assigned this Oct 11, 2026
@yeomin4242

Copy link
Copy Markdown
Author

@Quinn-With-Two-Ns

Thanks for clarifying. I mainly wanted to contribute to the Java SDK and don’t have a specific production use case for this. I’ll keep the PR while the team decides how to approach this across SDKs.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Add counter metric for unaccessed failed promises

3 participants