Repository navigation
Add cross-language encoded tracing header coverage - #943
Draft
Sushisource wants to merge 7 commits into
Draft
Sushisource wants to merge 7 commits into
Sushisource wants to merge 7 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
run-cross-languagesubcommand for feature folders marked with"crossLanguage": true. A conventionaldriver/program chooses scenarios and pairs; the runner discovers participant files and prepares each selected SDK once. No separate interop folder, embedded language sources, or runner-owned Cartesian product.tracing/encoded_headersparticipants using real tracing integrations for .NET, Go, Java, Python, Ruby, Rust, and TypeScript. The feature verifies encoded history, caller/workflow trace identity, input/result round-trip, and absence of failed Workflow Tasks. It rejects double encoding and never decodes headers on an SDK's behalf.main, retaining Go 1.51.0, Python 3.11/strict SDK-install failures, and .NET cleanup fixes alongside the role support.Why?
Regression coverage for temporalio/sdk-typescript#514, especially the reported .NET → TypeScript encoded tracing header failure, and cross-SDK evidence for the producer-specific opt-ins merged in temporalio/sdk-typescript#2579, temporalio/sdk-go#2818, temporalio/sdk-java#3165, and temporalio/sdk-rust#1734.
The feature driver owns pair policy so the runner can also support future cross-language replay, activity, or chained scenarios without hardcoding a matrix model.
Draft: waiting for published SDKs
Checked GitHub releases and the actual package registries on 2026-11-13. Merged is not the same as published:
codecHeaders/encodeClientHeaderssupportOpenTracingOptions.Builder.setEncodeHeaders(boolean)go.temporal.io/sdk/contrib/opentelemetryv0.8.1TracerOptions.EncodeHeaders; Go SDK v1.51.0 itself already includes the core changesBefore marking ready:
features/go.modand sums.latest.releaseis selected by the harness).PHP has no participant because its inspected SDK has no tracing integration; no synthetic implementation is substituted.
Checklist
Related issue: Normalize Header Data Conversion across languages #850. This PR remains draft until the releases above are available.
How was this tested:
Passed after merging current features
main: all 16 released-SDK client/worker pairs, .NET 1.22.0 × Python 1.36.0 × Ruby 1.11.0 × Rust 1.2.0, against Temporal CLI 1.10.0 / Server 1.32.2. No local SDK checkout, snapshot dependency, or temporary SDK source patch was used for this matrix.go run . run-cross-language \ --sdk-language cs --sdk-language py --sdk-language rb --sdk-language rs \ --sdk-version cs=1.22.0 --sdk-version py=1.36.0 \ --sdk-version rb=1.11.0 --sdk-version rs=1.2.0 tracing/encoded_headersAlso passed:
go test ./cmd ./sdkbuildharness/go:go test ./crosslanguage ./cmd ./harnessgo test .dotnet test tests/dotnet/Temporalio.Features.Harness.Tests.csproj: 9 passedharness/rust:cargo test --locked --features cross-language(7 passed),cargo clippy --locked --features cross-language -- -D warnings, andcargo fmt --checknpm run build, targeted TypeScript ESLint, Python preparation's mypy check (221 source files), andgit diff --checkConfirmed actual release blockers (these runs failed and are not counted as passes):
unknown field EncodeHeaders.NoSuchMethodExceptionforsetEncodeHeaders(boolean).Unknown encoding: binary/encryptedinextractContextFromHeaders.Earlier branch development validated all 49 combinations using local SDK changes; that is not evidence that the current published versions support the full matrix. Full cross-language release validation remains blocked as listed above. Remote PR CI has not yet been verified.
Any docs updates needed? Runner usage is in the root README; the feature README documents the codec contract, participant roles, released-version command, and outstanding release requirements.