You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Ensure .NET harness stops workers when features return null or throw #936
Codex helped spot a small cleanup issue with our .NET harness
Runner.RunAsync skips worker cleanup when ExecuteAsync returns null or when execution, result checks, or history checks throw. This leaves the worker polling while subsequent features run. This doesn't make sense for things like Standalone Activity, since there is no workflow handle to return, so they would either need to call a dummy workflow to get a handle, or manually call StopWorker() themselves.
Returning null is supported by IFeature.ExecuteAsync to skip workflow result and history checks. schedule/duplicate_error and the standalone activity feature in #934 both use this.
We should move cleanup into a finally block using StopWorker(). This should also work for features that explicitly stop or restart their worker. If cleanup throws, we should make sure to preserve the original test failure.
Activity