Repository navigation
Make translation microservice case-insensitive; fix Zulu hello/goodbye - #39
Closed
anthonywittig wants to merge 2 commits into
Closed
anthonywittig wants to merge 2 commits into
anthonywittig wants to merge 2 commits into
Conversation
|
|
The testing-code exercise has learners change "Hello" to "Goodbye", but the microservice only accepted lowercase terms. Lowercase the term and language code before lookup. Also swap the Zulu hello/goodbye translations, which were reversed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
anthonywittig
force-pushed
the
microservice-ignore-case
branch
from
October 21, 2026 21:50
ebb0160 to
eca168e
Compare
Contributor
Author
|
Closing to reopen as a fresh PR so the CLA check picks up the corrected commit author. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HellotoGoodbye, but the microservice only matched lowercase terms, so both were rejected as invalid. Terms and language codes are now lowercased before lookup. Error messages still echo the original input.hello/goodbyetranslations were swapped ("sawubona" is hello, "hamba kahle" is goodbye).hellotogoodbye, lowercase, to match the term used in the test code.Testing
Checked with Flask's test client:
Goodbye/fr→Au revoir;HELLO/FR→Bonjourgoodbye/xqandnope/frstill return errors🤖 Generated with Claude Code