node: sign bridge vote-extensions via checkpoint/attestation RPCs#1034
Open
diorwave wants to merge 6 commits into
Open
node: sign bridge vote-extensions via checkpoint/attestation RPCs#1034diorwave wants to merge 6 commits into
diorwave wants to merge 6 commits into
Conversation
Contributor
|
The reason for this pr is to protect the signer from unauthorised tx. With blind sign someone with access to the layer server can steal the funds. |
…alidated-bridge-signing # Conflicts: # go.mod # go.sum
diorwave
force-pushed
the
feat/validated-bridge-signing
branch
from
efe5983 to
324cc32
Compare
Contributor
Author
|
right, node now signs via checkpoint/attestation rpcs, so blind SignRaw can be dropped and a compromised layer server cant steal funds. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SignOracleAttestation; node asserts the returned 64-byte sig equals the expected value.