Skip to content

fix: ml-services-implementation-plan#64

Merged
techySPHINX merged 1 commit into
mainfrom
fix/copilot-review-recommendations
Mar 17, 2026
Merged

fix: ml-services-implementation-plan#64
techySPHINX merged 1 commit into
mainfrom
fix/copilot-review-recommendations

Conversation

@techySPHINX

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI review requested due to automatic review settings March 17, 2026 19:04
@github-project-automation github-project-automation Bot moved this to Backlog in Nivesh Mar 17, 2026
@techySPHINX techySPHINX merged commit 803e877 into main Mar 17, 2026
4 of 5 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in Nivesh Mar 17, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces an ML services remediation/execution planning document set (roadmap, checklist, sprint tickets, and an agent profile), but it also removes a large set of mobile design assets and deletes the ml-services/requirements.txt dependency manifest.

Changes:

  • Added ml-services-execution-plan/ documentation package (executive plan, roadmap, checklist, sprint ticket plan).
  • Added a GitHub agent definition for backend ↔ ML integration work.
  • Removed mobile design assets/docs and removed ml-services/requirements.txt.

Reviewed changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
mobile_design/src/utils/validators.ts Deleted mobile-design validators utilities.
mobile_design/src/utils/index.ts Deleted mobile-design utils barrel export.
mobile_design/src/utils/formatAmount.ts Deleted mobile-design amount formatting utility.
mobile_design/src/utils/constants.ts Deleted mobile-design constants.
mobile_design/src/utils/categories.ts Deleted mobile-design spending categories definitions.
mobile_design/src/theme/typography.ts Deleted mobile-design typography tokens.
mobile_design/src/theme/spacing.ts Deleted mobile-design spacing/border/icon tokens.
mobile_design/src/theme/shadows.ts Deleted mobile-design shadow tokens.
mobile_design/src/theme/index.ts Deleted mobile-design theme barrel export.
mobile_design/src/theme/colors.ts Deleted mobile-design color tokens/themes.
mobile_design/src/theme/animations.ts Deleted mobile-design animation presets.
mobile_design/src/theme/ThemeProvider.tsx Deleted mobile-design ThemeProvider implementation.
mobile_design/SOP_NIVESH_MOBILE_APP.md Deleted the mobile SOP/blueprint document.
ml-services/requirements.txt Deleted the primary ML services dependency file (currently referenced by the Docker build).
ml-services-execution-plan/SPRINT_WISE_TICKET_PLAN.md Added sprint ticket plan for remediation work.
ml-services-execution-plan/ML_SERVICES_REMEDIATION_ROADMAP.md Added remediation roadmap (phases, outcomes, risks).
ml-services-execution-plan/ML_SERVICES_EXECUTIVE_PLAN.md Added executive anchor doc for the remediation program.
ml-services-execution-plan/ML_SERVICES_EXECUTION_CHECKLIST.md Added gated execution checklist and evidence capture template.
.github/agents/nivesh-backend-ml-integration.agent.md Added a Copilot agent profile for backend/ML integration work.
Comments suppressed due to low confidence (1)

ml-services/requirements.txt:1

  • Deleting this file breaks the ml-services container build: ml-services/Dockerfile still does COPY requirements.txt . and installs from it, so the ml-api image build in docker-compose.yml will fail. Either restore ml-services/requirements.txt (even as a thin wrapper) or update the Dockerfile and any referenced docs/scripts to use the new canonical dependency file (e.g. core_requirements.txt).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


Document owner: Principal Architecture Office
Document date: 2026-03-17
Execution package: docs/ml-services-execution-plan
Comment on lines +8 to +13
## 1) Purpose

This document is the executive control anchor for the ML services remediation program.

It links strategy, execution checklist, and sprint tickets into one governed package so implementation can start without ambiguity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants