fix: ml-services-implementation-plan#64
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces an ML services remediation/execution planning document set (roadmap, checklist, sprint tickets, and an agent profile), but it also removes a large set of mobile design assets and deletes the ml-services/requirements.txt dependency manifest.
Changes:
- Added
ml-services-execution-plan/documentation package (executive plan, roadmap, checklist, sprint ticket plan). - Added a GitHub agent definition for backend ↔ ML integration work.
- Removed mobile design assets/docs and removed
ml-services/requirements.txt.
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
mobile_design/src/utils/validators.ts |
Deleted mobile-design validators utilities. |
mobile_design/src/utils/index.ts |
Deleted mobile-design utils barrel export. |
mobile_design/src/utils/formatAmount.ts |
Deleted mobile-design amount formatting utility. |
mobile_design/src/utils/constants.ts |
Deleted mobile-design constants. |
mobile_design/src/utils/categories.ts |
Deleted mobile-design spending categories definitions. |
mobile_design/src/theme/typography.ts |
Deleted mobile-design typography tokens. |
mobile_design/src/theme/spacing.ts |
Deleted mobile-design spacing/border/icon tokens. |
mobile_design/src/theme/shadows.ts |
Deleted mobile-design shadow tokens. |
mobile_design/src/theme/index.ts |
Deleted mobile-design theme barrel export. |
mobile_design/src/theme/colors.ts |
Deleted mobile-design color tokens/themes. |
mobile_design/src/theme/animations.ts |
Deleted mobile-design animation presets. |
mobile_design/src/theme/ThemeProvider.tsx |
Deleted mobile-design ThemeProvider implementation. |
mobile_design/SOP_NIVESH_MOBILE_APP.md |
Deleted the mobile SOP/blueprint document. |
ml-services/requirements.txt |
Deleted the primary ML services dependency file (currently referenced by the Docker build). |
ml-services-execution-plan/SPRINT_WISE_TICKET_PLAN.md |
Added sprint ticket plan for remediation work. |
ml-services-execution-plan/ML_SERVICES_REMEDIATION_ROADMAP.md |
Added remediation roadmap (phases, outcomes, risks). |
ml-services-execution-plan/ML_SERVICES_EXECUTIVE_PLAN.md |
Added executive anchor doc for the remediation program. |
ml-services-execution-plan/ML_SERVICES_EXECUTION_CHECKLIST.md |
Added gated execution checklist and evidence capture template. |
.github/agents/nivesh-backend-ml-integration.agent.md |
Added a Copilot agent profile for backend/ML integration work. |
Comments suppressed due to low confidence (1)
ml-services/requirements.txt:1
- Deleting this file breaks the ml-services container build:
ml-services/Dockerfilestill doesCOPY requirements.txt .and installs from it, so theml-apiimage build indocker-compose.ymlwill fail. Either restoreml-services/requirements.txt(even as a thin wrapper) or update the Dockerfile and any referenced docs/scripts to use the new canonical dependency file (e.g.core_requirements.txt).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| Document owner: Principal Architecture Office | ||
| Document date: 2026-03-17 | ||
| Execution package: docs/ml-services-execution-plan |
Comment on lines
+8
to
+13
| ## 1) Purpose | ||
|
|
||
| This document is the executive control anchor for the ML services remediation program. | ||
|
|
||
| It links strategy, execution checklist, and sprint tickets into one governed package so implementation can start without ambiguity. | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.