fix: lazy-load text-to-speech websocket peer#407
Open
alceops wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #406.
This keeps the
wspeer dependency optional for normal SDK imports by changing the Text-to-Speech websocket wrapper to importwsonly as a type and require the runtime package whenTextToSpeechWSis actually constructed. Ifwsis missing at that point, the constructor now throws a targeted optional-peer error instead of makingimport telnyxfail for every consumer.I also added a regression test that mocks
wsas unavailable and verifies:require('telnyx')still succeeds withoutwson diskTextToSpeechWSis the point where the missing optional peer error is raisedVerification in this environment:
git diff --checkrequire('ws')is deferredI could not run the Jest suite locally because this cron runtime does not have Node/npm/pnpm installed.