Allow empty config values to fallback to cluster defaults#2885
Open
yunasora wants to merge 3 commits into
Open
Allow empty config values to fallback to cluster defaults#2885yunasora wants to merge 3 commits into
yunasora wants to merge 3 commits into
Conversation
…r default by filtering empty configs
AlexisSouquiere
requested changes
May 13, 2026
AlexisSouquiere
left a comment
AlexisSouquiere
left a comment
Collaborator
There was a problem hiding this comment.
Please revert your changes on the package-lock.json and application.yml files
| (configs != null ? configs : ImmutableMap.<String, String>of()) | ||
| .entrySet() | ||
| .stream() | ||
| // Triggering GitHub Actions for testing #2601 |
Collaborator
There was a problem hiding this comment.
Please remove this comment
| .entrySet() | ||
| .stream() | ||
| // Triggering GitHub Actions for testing #2601 | ||
| .filter(r -> r.getValue()!=null&&!r.getValue().isEmpty()) |
Collaborator
There was a problem hiding this comment.
Please reformat this line
| @@ -38,7 +38,7 @@ class TopicCreate extends Form { | |||
| partition: Joi.number().min(1).label('Partition').required(), | |||
| replication: Joi.number().min(1).label('Replication').required(), | |||
| cleanup: Joi.string().required(), | |||
Collaborator
There was a problem hiding this comment.
allow('') should be there too to allow not sending cleanup policy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2601
When creating a new topic, if a user leaves
cleanup.policyorretentionblank (intending to use the cluster's default settings), the process previously failed. This PR fixes the issue across both the frontend and backend.Changes made:
.filter()in the controller to remove empty configuration values ("") from the request payload, preventing Kafka from rejecting them.TopicCreate.jsxto.allow('')for the retention field, ensuring the UI doesn't block the submission when the field is cleared.Testing: