Installer#2
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds build artifacts and intermediate files for C++ module compilation across multiple Visual Studio plugins, along with an installation marker file.
Changes:
- Addition of C++ STL module build artifacts (std and std.compat) for Visual Studio 2022
- Addition of installation marker file for x64 platform
Reviewed changes
Copilot reviewed 137 out of 547 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/plugins/pak/vcxproj/salamander/Release_x64/plugins/pak/lang/Intermediate/microsoft/STL/* | Build artifacts for C++ modules in pak plugin language build |
| src/plugins/pak/vcxproj/salamander/Release_x64/plugins/pak/Intermediate/microsoft/STL/* | Build artifacts for C++ modules in pak plugin |
| src/plugins/nethood/vcxproj/salamander/Release_x64/plugins/nethood/lang/Intermediate/microsoft/STL/* | Build artifacts for C++ modules in nethood plugin language build |
| src/plugins/nethood/vcxproj/salamander/Release_x64/plugins/nethood/Intermediate/microsoft/STL/* | Build artifacts for C++ modules in nethood plugin |
| src/plugins/mmviewer/vcxproj/salamander/Release_x64/plugins/mmviewer/lang/Intermediate/microsoft/STL/* | Build artifacts for C++ modules in mmviewer plugin language build |
| src/plugins/mmviewer/vcxproj/salamander/Release_x64/plugins/mmviewer/Intermediate/microsoft/STL/* | Build artifacts for C++ modules in mmviewer plugin |
| src/plugins/ieviewer/vcxproj/salamander/Release_x64/plugins/ieviewer/lang/Intermediate/microsoft/STL/* | Build artifacts for C++ modules in ieviewer plugin language build |
| src/plugins/ieviewer/vcxproj/salamander/Release_x64/plugins/ieviewer/Intermediate/microsoft/STL/* | Build artifacts for C++ modules in ieviewer plugin |
| src/plugins/ftp/vcxproj/salamander/Release_x64/plugins/ftp/lang/Intermediate/microsoft/STL/* | Build artifacts for C++ modules in ftp plugin language build |
| src/plugins/ftp/vcxproj/salamander/Release_x64/plugins/ftp/Intermediate/microsoft/STL/* | Build artifacts for C++ modules in ftp plugin |
| src/plugins/folders/vcxproj/salamander/Release_x64/plugins/folders/lang/Intermediate/microsoft/STL/* | Build artifacts for C++ modules in folders plugin language build |
| Instalator/x64 | Marker file indicating x64 installation target |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -0,0 +1,67 @@ | |||
| Software License Agreement for Altap Salamander. | |||
|
|
|||
| This is a legal agreement ("Agreement") between you (either an individual or | |||
There was a problem hiding this comment.
Please change to Taskscape Ltd instead of "ALTAP"
There was a problem hiding this comment.
We should never commit binary files. These should go to release (see github project releases)
| *.bak | ||
| *.backup | ||
|
|
||
| # Wyjątek dla gotowego instalatora |
There was a problem hiding this comment.
There should be no folder "instalator" or it should have been empty. Files should be part of release (see GitHub project releases). There should be no Polish titles or comments because it is very expensive to locate them and remove.
There was a problem hiding this comment.
I don't think this debug file is part of the installer task
| // search from the end for the character after which we can copy "..." and it fits in the column | ||
| while (fitChars > 0 && DrawItemAlpDx[fitChars - 1] + TextEllipsisWidth > textWidth) | ||
| fitChars--; | ||
| // copy a part of the original string to another buffer |
There was a problem hiding this comment.
I don't think removing those lines should be part of adding or updating the installer
No description provided.