chore(deps): upgrade rustyline 15 → 17 and gate v18+ on dashboard approval#160
Merged
Conversation
…roval
- tools/telepath/Cargo.toml: rustyline "15" → "17"
- tools/telepath/Cargo.lock: refresh via cargo update -p rustyline
- renovate.json:
- restore constraints.rust to "1.88.0" (was incorrectly bumped to "1.95.0"
in #151, conflicting with AGENTS.md MSRV policy)
- add packageRule requiring dashboard approval for rustyline major bumps,
since v18 needs File::lock stabilized in Rust 1.89 (MSRV-incompatible)
Closes the v18 Renovate PR #154; re-evaluate v18 only after a deliberate
MSRV bump.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
1 task
There was a problem hiding this comment.
Pull request overview
Upgrades rustyline from 15 to 17 in tools/telepath to gain v16/v17 improvements while staying within MSRV 1.88 (v18 requires Rust 1.89 due to File::lock stabilization). Also corrects the Renovate constraints.rust value that was incorrectly bumped to 1.95.0 and adds a dashboard-approval rule to prevent future MSRV-incompatible rustyline major bumps.
Changes:
- Bump
rustylinedependency from"15"to"17"and refreshCargo.lock(pulls innix 0.30.1,windows-sys 0.60.2). - Restore
constraints.rustinrenovate.jsonto"1.88.0". - Add a Renovate rule gating
rustylinemajor bumps behind Dependency Dashboard approval.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tools/telepath/Cargo.toml | Bumps the optional rustyline dep to v17. |
| tools/telepath/Cargo.lock | Lockfile refresh for rustyline 17.0.2 and transitive deps. |
| renovate.json | Restores Rust MSRV constraint and gates rustyline major updates. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tools/telepath/Cargo.toml: rustyline"15"→"17"(v17.0.2)tools/telepath/Cargo.lock: refreshed viacargo update -p rustylinerenovate.json:constraints.rustto"1.88.0"(was incorrectly bumped to"1.95.0"in chore(deps): Update rust Docker tag to v1.95.0 #151 by Renovate itself, causing it to propose MSRV-incompatible updates)dependencyDashboardApprovalrule for rustyline major bumps (same pattern as probe-rs)Background
Renovate PR #154 (
rustyline 15 → 18) fails theMSRV (1.88)CI gate because rustyline v18 replacesfd-lockwithstd::fs::File::lock()(upstream PR #909), which was stabilized in Rust 1.89 (tracking issue rust-lang/rust#130994).Upgrading to v17 instead gives us the v16/v17 improvements (grapheme clusters, SIGINT support, partial-refresh fix) while staying within MSRV 1.88. The rustyline API surface used in
tools/telepath/src/cmd/shell.rs(Editor,Helper/Hinter/Highlighter/Validator/Completer,DefaultHistory,ReadlineError) is fully compatible across v15–v17.Test plan
cargo +1.88.0 buildpasses (MSRV gate reproduced locally)just cigreen (fmt-check + clippy + test + host-pty-smoke + mcp-test)Closes #154
🤖 Generated with Claude Code