Fix broken Quick Start and rename to mmoe-recsys#13
Merged
Conversation
The Quick Start was missing two critical steps: nothing populated the feature store with user/item data, and the ranking ONNX model lived in a different directory than the retrieval models. Added populate_feature_store.py, example_client.py, and updated the pipeline steps. Also renamed project references from tanay-recsys-v1 to mmoe-recsys and lowered MAX_RETRIEVAL_K from 1000 to 900 to stay within SQLite's default 999-parameter limit. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/populate_feature_store.py— reads users/items parquet and populates SqliteFeatureStore (the missing step that caused serve.py to return empty results)scripts/example_client.py— runnable gRPC client with CLI args for quick testingcpstep in Quick Start to copy ranking ONNX model alongside retrieval modelstanay-recsys-v1tommoe-recsys(pyproject.toml, CI badge, project URLs)MAX_RETRIEVAL_Kfrom 1000 to 900 to stay within SQLite's default 999-parameter limitTest plan
🤖 Generated with Claude Code