Skip to content

Release/v0.4.1#33

Merged
tamada merged 5 commits into
mainfrom
release/v0.4.1
Nov 5, 2025
Merged

Release/v0.4.1#33
tamada merged 5 commits into
mainfrom
release/v0.4.1

Conversation

@tamada

@tamada tamada commented Nov 5, 2025

Copy link
Copy Markdown
Owner

The purpose of this release is to evaluate the generate-note option of gh release create command.

@tamada tamada added this to the v1.0.0 milestone Nov 5, 2025
@tamada
tamada requested a review from Copilot November 5, 2025 03:07
@tamada tamada added the enhancement New feature or request label Nov 5, 2025

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR bumps the project version from v0.4.0 to v0.4.1 and refactors the GitHub Actions workflow to use the GitHub CLI (gh) for release management instead of deprecated GitHub Actions.

  • Version bumped from 0.4.0 to 0.4.1 across all configuration files
  • GitHub Actions workflow modernized to use gh CLI commands for release creation and asset uploads
  • Replaced deprecated softprops/action-gh-release and actions/upload-release-asset with gh CLI equivalents

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
docs/content/_index.md Updated version badges from v0.4.0 to v0.4.1
README.md Updated version badges from v0.4.0 to v0.4.1
Dockerfile Updated VERSION ARG from 0.4.0 to 0.4.1
Cargo.toml Updated workspace package version from 0.4.0 to 0.4.1
.github/workflows/publish.yaml Refactored release workflow to use gh CLI; renamed job from release to finalize_release; removed deprecated GitHub Actions
Comments suppressed due to low confidence (1)

.github/workflows/publish.yaml:10

  • The setup job uses gh CLI commands that require write permissions to create releases, but no permissions block is defined. Add a permissions block with contents: write to ensure the job has sufficient permissions to create and manage releases.
  setup:
    runs-on: ubuntu-latest

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +26 to +31
run: |
gh release create v${{ steps.vars.outputs.tag }} \
--draft \
--repo $GITHUB_REPOSITORY \
--title "Release v${{ steps.vars.outputs.tag }}" \
--generate-notes

Copilot AI Nov 5, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The gh release create command requires authentication but no env section with GH_TOKEN or GITHUB_TOKEN is defined. Add an env section with GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} to ensure the command can authenticate properly, similar to the finalize_release job at line 205.

Copilot uses AI. Check for mistakes.
cp -r README.md LICENSE assets dist/$DIST/$DIR
cp target/${{ matrix.target }}/release/${{ matrix.artifact_name }}-cli dist/$DIST/$DIR/${{ matrix.artifact_name }}
tar cvfz dist/${{ matrix.asset_name }}.tar.gz -C dist/$DIST $DIR
gh release upload v${{ needs.setup.outputs.tag }} dist/${{ matrix.asset_name }}.tar.gz --repo $GITHUB_REPOSITORY

Copilot AI Nov 5, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The gh release upload command requires authentication but no environment variable is set in this step. Add env with GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} to the step or to the job level to ensure proper authentication.

Copilot uses AI. Check for mistakes.
Comment on lines 33 to 34
publish:
runs-on: ${{ matrix.os }}

Copilot AI Nov 5, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The publish job uses gh release upload command at line 138 which requires write permissions, but no permissions block is defined. Add a permissions block with contents: write to ensure the job can upload release assets.

Copilot uses AI. Check for mistakes.
release:
finalize_release:
needs: publish
runs-on: ubuntu-latest

Copilot AI Nov 5, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The finalize_release job uses gh release edit command at line 204 which requires write permissions, but no permissions block is defined. Add a permissions block with contents: write to ensure the job can modify releases.

Suggested change
runs-on: ubuntu-latest
runs-on: ubuntu-latest
permissions:
contents: write

Copilot uses AI. Check for mistakes.
Comment thread docs/content/_index.md
[![Docker](https://img.shields.io/badge/Docker-ghcr.io/tamada/gixor:0.4.1-blue?logo=docker)](https://github.com/tamada/gixor/pkgs/container/gixor/)
[![Homebrew](https://img.shields.io/badge/Homebrew-tamada/tap/gixor-blue?logo=homebrew)](https://github.com/tamada/homebrew-tap)

Gixor is Git Ignore Managenemnt System for Multiple Repositories.

Copilot AI Nov 5, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected spelling of 'Managenemnt' to 'Management'.

Suggested change
Gixor is Git Ignore Managenemnt System for Multiple Repositories.
Gixor is Git Ignore Management System for Multiple Repositories.

Copilot uses AI. Check for mistakes.
@coveralls

coveralls commented Nov 5, 2025

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 19093148129

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 54.823%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cli/src/main.rs 0 1 0.0%
Totals Coverage Status
Change from base Build 19089604908: 0.0%
Covered Lines: 773
Relevant Lines: 1410

💛 - Coveralls

@tamada
tamada merged commit c3fe857 into main Nov 5, 2025
3 checks passed
@tamada
tamada deleted the release/v0.4.1 branch January 13, 2026 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants