Conversation
addedComment only checked the commenter was logged in, not that they had write access. Gate it behind isWritable, like the manual "Run build" button already does.
PRs from forks auto-triggered a build on open and on every push to the fork branch, with no review step, running the fork's code directly on the host (or against Docker). Add a per-repo buildForkPullRequests flag (default off) and gate both trigger paths on it. Merges are exempt since they build the base repo's own already-reviewed branch.
aadrian
force-pushed
the
fix/build-timeout
branch
from
September 21, 2026 19:07
08820a1 to
69ca71e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on top of #98 and #99, please merge those first.
runProcess polled process.isAlive() indefinitely, so a hung build script could tie up a worker thread forever. Adds an admin-configurable buildTimeoutMinutes setting (default 60, 0 disables it) and kills the process once it's exceeded.