fix: dispose leaked DbConnection and DbCommand in SQL layer#107
Draft
sylvester-henrique with Copilot wants to merge 2 commits into
Draft
fix: dispose leaked DbConnection and DbCommand in SQL layer#107sylvester-henrique with Copilot wants to merge 2 commits into
sylvester-henrique with Copilot wants to merge 2 commits into
Conversation
…2, await DbCommand in ExecuteNonQueryAsync, dispose DbCommand in AlterTableColumnsAsync Co-authored-by: sylvester-henrique <19980165+sylvester-henrique@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Analyze memory leaks in DbConnection and DbCommand
fix: dispose leaked DbConnection and DbCommand in SQL layer
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three disposal bugs in
Take.Elephant.Sqlcausing connection/command leaks:DbDataReaderAsyncEnumerator2.MoveNextAsync—DbConnectionfrom factory stored in local variable, never disposed. Added_dbConnectionfield and disposal inDisposeAsync(), matching the pattern inDbDataReaderAsyncEnumerator.DbConnectionExtensions.ExecuteNonQueryAsync— ReturnsTask<int>withoutawait, so theusingblock disposes theDbCommandbefore the async operation completes. Made methodasync.DatabaseSchema.AlterTableColumnsAsync—connection.CreateCommand()in loop body never wrapped inusing.💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.