This repository was archived by the owner on May 3, 2024. It is now read-only.
New invalid tx#157
Open
CeciliaZ030 wants to merge 34 commits into
Open
Conversation
github-actions
Bot
removed
T-bench
crate-circuit-benchmarks
crate-integration-tests
labels
[invalid tx] Write tx id and revert state circuit changes
…rcuits into new-invalid-tx
github-actions
Bot
added
crate-circuit-benchmarks
crate-integration-tests
T-bench
labels
4 tasks
github-merge-queue Bot
pushed a commit
to privacy-ethereum/zkevm-circuits
that referenced
this pull request
Dec 6, 2023
### Description Resolves #1611 Upstreamed from taikoxyz#157 with some additional changes. Adds an additional execution state for transactions that are invalid and need to be skipped. This execution state needs to be enabled instead of the normal BeginTx/EndTx for valid transactions. Support skipping the following invalid transactions for now: - nonce too low - nonce too high - intrinsic gas too low - insufficient funds for gas * price + value More cases will be added in future PRs. ### Issue Link #1611 ### Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update ### Contents - [_item_] ### Rationale [_design decisions and extended information_] ### How Has This Been Tested? - Added required unit tests - make test-all passes --------- Co-authored-by: Cecilia Zhang <zhangyixin319@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Handel invalid Tx using error state. Replacing #115
Issue Link
#25