Skip to content
This repository was archived by the owner on May 3, 2024. It is now read-only.

Support eip-1559 and Evm-circuit in aggregation#136

Merged
smtmfft merged 61 commits into
taikoxyz:feat/for-a6-releasefrom
johntaiko:feat/evm_circuit_1559
Sep 21, 2023
Merged

Support eip-1559 and Evm-circuit in aggregation#136
smtmfft merged 61 commits into
taikoxyz:feat/for-a6-releasefrom
johntaiko:feat/evm_circuit_1559

Conversation

@johntaiko

@johntaiko johntaiko commented Aug 11, 2023

Copy link
Copy Markdown
Member

Previous: smtmfft#18

Tasks:

@johntaiko

Copy link
Copy Markdown
Member Author

@Brechtpd Now, we use taiko flag to enable the anchor logics.
Also, we only use the type-2-transaction for our zkevm. And update signature to eip-2718

@johntaiko johntaiko force-pushed the feat/evm_circuit_1559 branch 2 times, most recently from e3451a5 to 2196cf8 Compare August 20, 2023 13:45
…es (privacy-ethereum#1424)

1. Add Shanghai related fields to chain config in geth-utils.

2. EIP-3651 (Warm COINBASE): add a new access-list write for coinbase to
Begin TX.

3. Part of EIP-3860 (Limit and meter initcode): only add gas cost of
init code to Begin TX (missing gas cost changes in Create and OOG
Create).

Issue
privacy-ethereum#1362

Local related PRs:
scroll-tech#497
scroll-tech#500
scroll-tech#507

Reference previous PR:
privacy-ethereum#1361

- [x] Breaking change (fix or feature that would cause existing
functionality to not work as expected)

Unit test cases of CI could pass with Shanghai geth traces.

---------

Co-authored-by: Zhang Zhuo <mycinbrin@gmail.com>
@johntaiko johntaiko force-pushed the feat/evm_circuit_1559 branch from 2196cf8 to 46c5125 Compare August 20, 2023 13:50
@johntaiko

johntaiko commented Aug 21, 2023

Copy link
Copy Markdown
Member Author

Using real data with one anchor transaction is passed in zkevm-chain. taikoxyz/zkevm-chain#6
@Brechtpd @smtmfft Please take look again

Comment thread zkevm-circuits/src/witness/block.rs Outdated
@Brechtpd

Copy link
Copy Markdown

Looked through the code again, all looks good to me!

@johntaiko johntaiko self-assigned this Aug 23, 2023
@johntaiko johntaiko force-pushed the feat/evm_circuit_1559 branch from b050ba5 to c1af675 Compare August 28, 2023 13:44
@johntaiko johntaiko force-pushed the feat/evm_circuit_1559 branch from 0dee923 to c1af675 Compare September 21, 2023 05:54
@johntaiko johntaiko changed the base branch from main to feat/for-a6-release September 21, 2023 06:05
@johntaiko johntaiko marked this pull request as ready for review September 21, 2023 06:06
@smtmfft smtmfft merged commit 1025748 into taikoxyz:feat/for-a6-release Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Integrate EVM circuit into TaikoSuperCircuit EIP1559 support

5 participants