Skip to content

test(websocket): wait for close callback - #16

Merged
taigrr merged 1 commit into
masterfrom
cd/round8-test-cleanup
Oct 19, 2026
Merged

taigrr merged 1 commit into
masterfrom
cd/round8-test-cleanup

Conversation

@taigrr

@taigrr taigrr commented Oct 9, 2026

Copy link
Copy Markdown
Owner

Summary

  • wait for the websocket close callback before asserting close state
  • fixes the coverage-mode race where the close goroutine had not updated the fake callback yet

Tests

  • go generate ./...
  • go test ./...
  • go test -cover ./...
  • go test -race ./...
  • staticcheck ./...

@taigrr
taigrr merged commit d22ea5b into master Oct 19, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant