Skip to content

perf(core): clone row template and slice active rows #4904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
lukecotter wants to merge 1 commit into
base: master
Choose a base branch
from
+13 −7
Draft

perf(core): clone row template and slice active rows #4904

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/js/core/RowManager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -768,7 +768,7 @@ export default class RowManager extends CoreFeature{
}

setActiveRows(activeRows){
this.activeRows = this.activeRows = Object.assign([], activeRows);
this.activeRows = activeRows.slice();
this.activeRowsCount = this.activeRows.length;
}

Expand Down
18 changes: 12 additions & 6 deletions src/js/core/row/Row.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@ import RowComponent from './RowComponent.js';
import Helpers from '../tools/Helpers.js';

export default class Row extends CoreFeature{

static rowTemplate = Row.createRowTemplate();

constructor (data, parent, type = "row"){
super(parent.table);

Expand All @@ -25,6 +28,7 @@ export default class Row extends CoreFeature{

this.created = false;


this.setData(data);
}

Expand All @@ -36,12 +40,7 @@ export default class Row extends CoreFeature{
}

createElement (){
var el = document.createElement("div");

el.classList.add("tabulator-row");
el.setAttribute("role", "row");

this.element = el;
this.element = Row.rowTemplate.cloneNode(false) ;
}

getElement(){
Expand Down Expand Up @@ -484,4 +483,11 @@ export default class Row extends CoreFeature{

return this.component;
}

static createRowTemplate(){
const rowTemplate = document.createElement("div");
rowTemplate.classList.add("tabulator-row");
rowTemplate.setAttribute("role", "row");
return rowTemplate;
}
}
Loading