@W-22390723: updated resource url to include tableau-mcp#341
Open
mattcfilbert wants to merge 3 commits into
Open
@W-22390723: updated resource url to include tableau-mcp#341mattcfilbert wants to merge 3 commits into
mattcfilbert wants to merge 3 commits into
Conversation
| */ | ||
| export function oauthProtectedResource(app: express.Application): void { | ||
| app.get('/.well-known/oauth-protected-resource', (_req, res) => { | ||
| app.get(`/${serverName}/.well-known/oauth-protected-resource`, (_req, res) => { |
Collaborator
There was a problem hiding this comment.
This doc has a few references to the old endpoint that need updating: https://tableau.github.io/tableau-mcp/docs/configuration/mcp-config/oauth
| if (missingScopes.length > 0) { | ||
| const { resourceUri } = getConfig().oauth; | ||
| const baseUrl = new URL(resourceUri).origin; | ||
| const resourceMetadataUrl = `${baseUrl}/tableau-mcp/.well-known/oauth-protected-resource`; |
Collaborator
There was a problem hiding this comment.
nit: not that it would likely ever change, but should probably use ${serverName} here instead of tableau-mcp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updated resource url to include /tableau-mcp
Type of Change
Checklist
npm run version. For example,use
npm run version:patchfor a patch version bump.environment variable or changing its default value.
Contributor Agreement
By submitting this pull request, I confirm that:
its Contribution Checklist.